Day 10/11: Refactoring!
I haven't blogged on Friday, so consider this the blog post for Friday and Monday!
On Friday I had to go to the dentist again, so not as much time available as I'd hoped. I was mainly busy with some more organizational stuff for the crowdfunding and general maintenance. I also finally added the backers file to the documentation!
Today I continued working on refactoring all QtWebKit-specific code so there's a well-defined API, and most (271) end-to-end tests pass by now:
The following commands/features now work again with QtWebKit:
- Opening a new window via JS
- :buffer completion
- Loading of marks
- Loading of sessions
- Passing through keys to a website
13 tests still fail:
The scroll and tabs ones should be trivial fixes. For downloads, editor, spawn and yankpaste some more work and extending the API will probably be needed.
I also started implementing the existing API for QtWebEngine - unfortunately API to get the scroll position from a QWebEngineView was only implemented in Qt 5.7, and the current PyQt 5.6 doesn't wrap that yet.
There's also no API to scroll the page - I tried emulating key presses like I did with QtWebKit, but for some reason that did nothing at all...